launchdarkly / android-client-sdk

LaunchDarkly Client-side SDK for Android
Other
45 stars 23 forks source link

Set LaunchDarklySdk tag for all Timber events #178

Closed audkar closed 2 years ago

audkar commented 2 years ago

Requirements

Related issues

17 #38 #113 #147 #173

Describe the solution you've provided

All Timber events should have one common TAG - LaunchDarklySdk

Describe alternatives you've considered

Just fixing a bug.

Additional context

Timber.tag(<..>) had to be called before logging each event. Previous implementation called tag() once per app lifecycle.

eli-darkly commented 2 years ago

Thanks - we were working on larger changes that would've also included this fix, but it makes sense to do it separately.

One nitpick in terms of Java coding standards: now that this is a method and not a constant/static final field, it should be log(), not LOG().

audkar commented 2 years ago

it should be log(), not LOG().

Renamed

aengelberg commented 2 years ago

Thank you again for submitting this change! I'll include it in the next patch release.