search

launchdarkly / android-client-sdk

LaunchDarkly Client-side SDK for Android
Other
45 stars 23 forks source link

Use FLAG_UPDATE_CURRENT to create PendingIntent #87

Closed sambroad closed 4 years ago

sambroad commented 4 years ago

Potential fix for: https://github.com/launchdarkly/android-client-sdk/issues/83 based on https://stackoverflow.com/a/29703161

gwhelanLD commented 4 years ago

Hi @sambroad,

Thanks for this PR. This is definitely an approach we are looking at for fixing #83, but we need to do a bit more investigation to validate that this is the approach we want to take on this issue.

We have not prioritized this work yet as initial triaging has indicated the conditions for triggering this issue should limit the impact substantially. That said, we hope to take on this work soon.

Thanks, @gwhelanLD

sambroad commented 4 years ago

Thanks for your answer. I appreciate you looking into this, and understand you need to be cautious not to introduce any side effects. This fix solved the same issue when we applied it in our codebase. https://github.com/launchdarkly/android-client-sdk/issues/83 is now the most reported crash in our app, so I look forward to seeing it prioritized soon.

gwhelanLD commented 4 years ago

We've just released version 2.9.1 of the Android SDK, which should address #83, although in a different manner than proposed in this PR. Please see the discussion on the issue for more information on our investigation and our ultimate solution.

I'm going to close this PR as the issue it was intended to address has now been closed. Thanks again for suggesting this change, even though we ultimately went with a different approach.