search

launchdarkly / api-client-go

LaunchDarkly API Client for Go
Other
8 stars 12 forks source link

Remove interface pointers from generated code and documentation #2

Closed moshegood closed 3 years ago

moshegood commented 3 years ago

This is in line with the PR to swagger to stop generating interface pointers for generated golang code. Notice how much cleaner the code is.

See: https://github.com/swagger-api/swagger-codegen/pull/10932

bwoskow-ld commented 3 years ago

Hi @moshegood ,

The code you modified is auto-generated. As such we can't accept this pull request; your changes will be overwritten when we next release this client.

I see that you also submitted a pull request to swagger-codegen. If you let us know when a new version is available we can look to update to it at that time to generate an updated client.

eli-darkly commented 3 years ago

Note that if we do start using a newer swagger-codegen that has this change, we'll need to bump the API client to a new major version, because such a change (while it is desirable) will be backward-incompatible with any existing code that uses the client.