search

launchdarkly / c-client-sdk

LaunchDarkly Client-side SDK for C/C++
Other
8 stars 13 forks source link

Fixes a header initialization that was being compiled out #78

Closed juancampa closed 2 years ago

juancampa commented 2 years ago

Requirements

Related issues

I noticed that this was being printed every few minutes:

[launchdarkly/src/ldthreads.c, 141] sending events failed deleting event batch

After enabling curl's verbose mode. I noticed that LD was responding with 400.

It turned out this header is being initialized inside an LD_ASSERT which, when compiled out, takes with it the initialization.

Describe the solution you've provided

Separate the assertion from the initialization

Describe alternatives you've considered

N/A

cwaldren-ld commented 2 years ago

Well, this is awkward 🤣

Thank you @juancampa . Would you mind re-targeting the PR to the contrib branch, which I've just created?

I'll then perform some testing and if all is good, put out a patch release.

Filed internally as 158131.

juancampa commented 2 years ago

Well, this is awkward 🤣

It happens :)

Would you mind re-targeting the PR to the contrib branch, which I've just created?

Done

juancampa commented 2 years ago

BTW, the reason I was looking into this is because we have an LD client that's not getting any flag updates and we can't figure out why. The stream seems to connect just fine, but when I change the flag value, nothing happens.

Any chance you guys have a quick way to diagnose something like this?

cwaldren-ld commented 2 years ago

Hi @juancampa , I'll point you towards our support team for that: https://support.launchdarkly.com/hc/en-us/requests/new. They should be able to help you promptly.

cwaldren-ld commented 2 years ago

Just an update, this should be resolved by 2.4.7.

juancampa commented 2 years ago

Sounds good. Thank you @cwaldren-ld