search

launchdarkly / c-client-sdk

LaunchDarkly Client-side SDK for C/C++
Other
7 stars 15 forks source link

Switch back to CircleCI executor for Linux release #97

Closed cwaldren-ld closed 1 year ago

cwaldren-ld commented 1 year ago

Reverts back to earlier state where CircleCI job is used for Linux build.

Switching to the default Docker executor used by Releaser didn't quite work, as it doesn't have the packages necessary to do a clean documentation build.

Additionally, that change - although not a huge deal - did slow down the release process, since the Linux job couldn't run concurrently as is the case when using CircleCI jobs.

The original reason for switching was because the curl dependency was already present in Releaser's default image. I'm ~updating~ (done) ld-c-sdk-ubuntu to contain that.

eli-darkly commented 1 year ago

Just to make sure there isn't a misunderstanding here - I don't get why "the default Docker executor used by Releaser ... doesn't have the packages necessary to do a clean documentation build" is a reason to keep using CircleCI mode. Releaser in Docker mode can use any Docker image that you specify, just as you can specify any Docker image in CircleCI. What you've done in this PR, besides switching to CircleCI, is to switch the Docker image from ldcircleci/ld-c-sdk-ubuntu:2 to ldcircleci/ld-c-sdk-ubuntu:5 but that is something you could've done anyway.

cwaldren-ld commented 1 year ago

Meant to ask about on Monday but sickness had other plans. Will clarify in Slack.