launchdarkly / cpp-sdks

C++ Client/Server SDKs
Other
5 stars 2 forks source link

refactor: Update context filter class to match preferred coding style #364

Closed keelerm84 closed 7 months ago

shortcut-integration[bot] commented 7 months ago

This pull request has been linked to Shortcut Story #228721: Anonymous attribute redaction for feature events.

keelerm84 commented 7 months ago

Feedback from https://github.com/launchdarkly/cpp-sdks/pull/363 mentioned that this file wasn't following the newly established conventions. So I'm fixing that in a separate PR.

There is one method on the context filter class, emplace, which I didn't convert to PascalCase. I see that emplace is a more common method name in C++, so I thought you may want to keep that consistent. Happy to change it if not.

cwaldren-ld commented 7 months ago

Let's have emplace use PascalCase as well.