fix: Evaluate should not share EvaluationStack between calls - Githubissues

launchdarkly / cpp-sdks

C++ Client/Server SDKs

Other

5 stars 2 forks source link

fix: Evaluate should not share EvaluationStack between calls #374

Closed cwaldren-ld closed 4 months ago

cwaldren-ld commented 4 months ago

Addresses #373.

cwaldren-ld commented 4 months ago

There are additional thread-safety concerns I've discovered while testing this. Specifically, although we may be able to make the evaluator thread safe, we need to ensure the data system implementations are thread safe as well.

Specific notes:

DataSystem::Initialized() needs to to be thread safe
If lazy loading, refreshing needs to be thread safe (the readers are supposed to be by definition, but the expiration tracker needs to be)
If background sync, the memory store is already thread safe.

Still, this PR is an incremental improvement and can be merged independently.