launchdarkly / cpp-sdks

C++ Client/Server SDKs
Other
5 stars 2 forks source link

refactor: only define constructors for Client types #418

Closed cwaldren-ld closed 1 month ago

cwaldren-ld commented 1 month ago

The Client types that follow pimpl idiom had warnings that they needed to define destructors as well to satisfy the rule of five.

We don't need to define move/copy/copy-assign/move-assign for these at all, instead we can follow the rule of zero since the only member is a std::unique_ptr.