launchdarkly / cpp-sdks

C++ Client/Server SDKs
Other
5 stars 2 forks source link

Provide "LDConfigSetProxyURI" in the 3.x client-side C/C++ SDK #426

Open ngangomsamananda opened 1 month ago

ngangomsamananda commented 1 month ago

Is your feature request related to a problem? Please describe. We are stuck on the end-of-life LDSDK v2.5.2 because "LDConfigSetProxyURI" is not available in the v3.x client-side C/C++ SDK.

Describe the solution you'd like Support for LDConfigSetProxyURI in the v3.x client-side C/C++ SDK for connecting to LaunchDarkly through a web proxy.

Describe alternatives you've considered

cwaldren-ld commented 1 month ago

Hi @ngangomsamananda , you filed this issue earlier: https://github.com/launchdarkly/cpp-sdks/issues/394

Was the workaround I provided not sufficient, or has the requirements changed?

ngangomsamananda commented 1 month ago

@cwaldren-ld the requirements have changed. Could you take up this on priority? We are stuck in the upgrade process. Thanks.

cwaldren-ld commented 1 month ago

Ok, what are the new requirements? Why does the previous workaround no longer work?

ngangomsamananda commented 1 month ago

The workaround LDClientConfigBuilder_ServiceEndpoints_RelayProxyBaseURL which you had provided supports only HTTP/HTTPS proxy. For certain use case we need a similar API of LDConfigSetProxyURI in new SDK for SOCKS proxies.

cwaldren-ld commented 1 month ago

Is it SOCKS4 or SOCKS5 or both? I will file a feature request, but I cannot promise any timeline.

ngangomsamananda commented 1 month ago

Hi @cwaldren-ld I got know to we need to support all kinds of proxy currently available in the world including HTTP/HTTPS and SOCKS. In the old version (v2.5.2) LDConfigSetProxyURI all types of proxy https://github.com/launchdarkly/c-client-sdk/blob/main/include/launchdarkly/config.h#L106 https://curl.se/ is the where the list of supported proxy is available in old version of SDK. Since we have a larger number of customers and the proxy is depending on the customer setup, we would consider any type of proxy currently available.

ngangomsamananda commented 1 month ago

We need the same feature of LDConfigSetProxyURI in the new SDK.