search

launchdarkly / dotnet-client-sdk

LaunchDarkly Client-side SDK for .NET
Other
7 stars 10 forks source link

Event FlagChanged doesn't trigger on creation a new flag #31

Closed tomertr closed 2 years ago

tomertr commented 3 years ago

The event FlagChanged doesn't trigger on creation of a new flag, it only triggers on changes made to flags that already existed during the last query to AllFlags.

To reproduce Register to the LdClient event FlagChanged then add a new flag to LaunchDarkly

Expected behavior The event should be triggered on the new flag added

SDK version Xamarin 1.2.0.0

OS/platform Windows 10

eli-darkly commented 3 years ago

Thanks for reporting this. I see where the flaw in the logic is, and it's pretty straightforward, so putting out a fix will only depend on our overall project/release pipeline which is a little backed up at the moment. I'll file it as low-hanging fruit to be addressed as soon as there's a chance.

eli-darkly commented 2 years ago

Sorry for the lack of an update on this issue before. This behavior is fixed in the new 2.0.0 release, as part of its somewhat different flag change event API (basically, instead of LdClient.FlagChanged it is now LdClient.FlagTracker.FlagValueChanged and the name of the argument type has changed). We probably won't put out a 1.x patch.