search

launchdarkly / dotnet-server-sdk-redis

Redis integration for the LaunchDarkly SDK for Server-side .NET
Other
2 stars 3 forks source link

Updating version of StackExchange.Redis #11

Closed peter-majeed closed 3 years ago

peter-majeed commented 3 years ago

Meant to address the issue stated @ https://github.com/launchdarkly/dotnet-server-sdk-redis/issues/10.

eli-darkly commented 3 years ago

Thanks for submitting this; I had already started the work, and there are some related changes that I'll want to make, but I can merge this into a temporary branch.

eli-darkly commented 3 years ago

Note - we normally wouldn't accept a PR that doesn't have a green build. The problem here is that you've changed the target frameworks without updating the CI configuration. I've already taken care of that on my own in-progress branch, so it's not a big deal, but just FYI that's something to watch out for when submitting.

peter-majeed commented 3 years ago

Aha, appreciate the FYI on the circle CI dependency. Also, thanks for jumping on this so fast! Given you're also working on this, I'll decline this PR tomorrow. Much appreciated all around

peter-majeed commented 3 years ago

Thanks again for all the comments here, @eli-darkly. I pushed the changes you'd suggested, but I'm closing this out given what we'd previously discussed.