search

launchdarkly / ios-client-sdk

LaunchDarkly Client-side SDK for iOS (Swift and Obj-C)
https://docs.launchdarkly.com/sdk/client-side/ios
Other
70 stars 84 forks source link

Warnings when building with Xcode 10.2 #167

Closed simonliotier closed 5 years ago

simonliotier commented 5 years ago

Hi,

We are using CocoaPods to integrate LaunchDarkly in our app. When building with Xcode 10.2, we get 14 warnings such as .../Pods/LaunchDarkly/Darkly/NSDictionary+LaunchDarkly.h:9:56: Pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified).

Xcode10_2

These warnings are displayed even if we are using the inhibit_all_warnings! flag in our Podfile, because the code causing the warning is in header files, and the flag does not work with header files (see this issue for more details).

Could you fix this warnings?

SDK version

Language version, developer tools

ElleSkye117 commented 5 years ago

same for us as well

rbaumbach commented 5 years ago

I'm seeing this issue as well.

davidfuzju commented 5 years ago

same here

rbaumbach commented 5 years ago

@simonliotier You can point to my GitHub repo in your Podfile until my changes make it into the next version of of the ios-client if you'd like.

torchhound commented 5 years ago

We added nullability type specifiers in 3.0.0