search

launchdarkly / ios-client-sdk

LaunchDarkly Client-side SDK for iOS (Swift and Obj-C)
https://docs.launchdarkly.com/sdk/client-side/ios
Other
70 stars 84 forks source link

Ambiguous access level #184

Closed wqz-leo closed 5 years ago

wqz-leo commented 5 years ago

Is your feature request related to a problem? Please describe.

This initialiser is private, but the struct and properties are public. Therefore, this struct cannot be created from outside of this package, and those two properties are not accessible. There might be a reason of this, but from a developer point of view it's a bit confusing.

Describe the solution you'd like Make initialiser public or struct and properties internal.

Describe alternatives you've considered N/A

Additional context N/A

torchhound commented 5 years ago

Hi @wqz-leo, thanks for bringing this up! How are you using Minima? Are you using the struct directly or using the public field in the LDConfig class? Is your usecase what's defined in the migration guide or something different?

wqz-leo commented 5 years ago

Hi @torchhound , sorry my bad, I was play around with the library and confused initially. Now I figured out the reason for this. Thanks for reply.