search

launchdarkly / ios-client-sdk

LaunchDarkly Client-side SDK for iOS (Swift and Obj-C)
https://docs.launchdarkly.com/sdk/client-side/ios
Other
69 stars 84 forks source link

SwiftPM - Tools Version 5.2 #233

Closed escakot closed 3 years ago

escakot commented 3 years ago

Is your feature request related to a problem? Please describe. Importing the LD SDK through SwiftPM will import dev/test dependencies which is not ideal. image

Describe the solution you'd like Updating to Swift Tools 5.2 and minor changes to Package.swift will resolve this. I've tested it on my own fork. Let me know if you would like to me to make a PR. image

Describe alternatives you've considered N/A

Additional context We're currently using Carthage to install the LD sdk. We're planning to switch over to SwiftPM soon.

gwhelanLD commented 3 years ago

Hi @escakot,

Great suggestion, we'd love to see a PR for this. We'd just need to verify that it should work across the various supported installation methods. Hopefully this sort of change should only reduce the complexity of including the SDK within applications.

Thanks, @gwhelanLD

gwhelanLD commented 3 years ago

Thanks again for your PR! I'm closing this issue now that it's been included in the 5.4.2 release.

Thanks, @gwhelanLD