Update Package.swift swift-tools-version 5.2

launchdarkly / ios-client-sdk

LaunchDarkly Client-side SDK for iOS (Swift and Obj-C)

https://docs.launchdarkly.com/sdk/client-side/ios

Other

69 stars 84 forks source link

Update Package.swift swift-tools-version 5.2 #234

Closed escakot closed 3 years ago

escakot commented 3 years ago

Requirements

[ ] I have added test coverage for new or changed functionality
[x] I have followed the repository's pull request submission guidelines
[x] I have validated my changes against all supported platform versions (Using the build commands in config.yml)

Describe the solution you've provided I've updated swift-tools-version to 5.2

Describe alternatives you've considered N/A

Additional context No updates required for swift-eventsource since it doesn't have dependencies.

bwoskow-ld commented 3 years ago

Hi @escakot,

Thank you for submitting a pull request to fix #233! At first glance the changes look reasonable. As @gwhelanLD mentioned a few days ago, we'll do some verification on our side and will get back to you.

Thanks, @bwoskow-ld

Filed internally as 98439.

escakot commented 3 years ago

Hi @bwoskow-ld,

For sure. Appreciate you guys for taking the time to test it out.

Thanks, @escakot

kreeger commented 3 years ago

Hey, what's the status on this? If it's been forgotten, I'd like to give it a friendly bump. If it helps, I've got an updated copy of this change, but sitting on top the latest of the v5 branch, in our fork of this project.

bwoskow-ld commented 3 years ago

Hi @kreeger ,

This issue hasn't been forgotten, but thanks for the friendly bump. Apologies for not getting to it yet.

gwhelanLD commented 3 years ago

Thanks for the contribution! It's been included in the 5.4.2 release.

Thanks, @gwhelanLD