Update Package.swift to support swift-tools-version:5.8

launchdarkly / ios-client-sdk

LaunchDarkly Client-side SDK for iOS (Swift and Obj-C)

https://docs.launchdarkly.com/sdk/client-side/ios

Other

70 stars 84 forks source link

Update Package.swift to support swift-tools-version:5.8 #308

Open pierre-wehbe opened 1 year ago

pierre-wehbe commented 1 year ago

Requirements

[X] I have added test coverage for new or changed functionality
[X] I have followed the repository's pull request submission guidelines
[X] I have validated my changes against all supported platform versions

Related issues

swift-tools-version:5.8 have deprecated the use of .package(name:xxx, url:xxx, from:xxx) to .package(url:xxx, from:xxx). This causes our internal SPM using 5.8 to break

Describe the solution you've provided

Update LD SPM to support 5.8

pierre-wehbe commented 1 year ago

In case 5.8 is a concern (since it becomes the minimum), I believe keeping 5.2 would still work

tanderson-ld commented 1 year ago

Hi @pierre-wehbe , thanks for opening this PR. One of our team will take a look to verify this has no adverse effects on our packages. Thank you!

tanderson-ld commented 11 months ago

HI @pierre-wehbe . We will be releasing support for XCode15 in the near future. During this work, we looked at the swift-tools-version you have proposed. Unfortunately that bump would be too drastic for our customer base at the moment. We are going to be bumping it from 5.2 to 5.3 however. Are you able to have your build process ignore the deprecation?