search

launchdarkly / ios-client-sdk

LaunchDarkly Client-side SDK for iOS (Swift and Obj-C)
https://docs.launchdarkly.com/sdk/client-side/ios
Other
68 stars 82 forks source link

feat: Add new identify method with time out support #341

Closed keelerm84 closed 4 months ago

keelerm84 commented 4 months ago

A callback provided to the identify method may not be executed for a long time under the right circumstances (e.g. the network is slow or unavailable).

Customers can now ensure their callbacks will fire within a specified time interval by calling the new LDClient.identify(context:timeOut:completion:) method.

shortcut-integration[bot] commented 4 months ago

This pull request has been linked to Shortcut Story #233103: Add timeout to identify handler.

tanderson-ld commented 4 months ago

I think using @kinyoklion's 1 identify in progress spec may be the only course of action to add the timeout support on top of the existing code (which does not support cancellation of identify in progress).

keelerm84 commented 4 months ago

Going to close this. Originally was thinking we might be able to make some concessions on the first round of this, but have decided against it.