launchdarkly / ios-client-sdk

LaunchDarkly Client-side SDK for iOS (Swift and Obj-C)
https://docs.launchdarkly.com/sdk/client-side/ios
Other
68 stars 82 forks source link

Add inspectors to this SDK #368

Closed shanepadgett closed 2 months ago

shanepadgett commented 3 months ago

Is your feature request related to a problem? Please describe. We would like to use the inspectors feature that is available via the Javascript SDKs in our iOS project.

Describe the solution you'd like Add inspector capability to this SDK.

Describe alternatives you've considered None

Additional context We use Datadog's RUM product and they support flag data gathering, but not from LD since inspectors aren't supported in the SDK.

tanderson-ld commented 2 months ago

Hi @shanepadgett , thank you for reaching out and letting us know you are interested in this feature. I will take a note to discuss with the team.

tanderson-ld commented 2 months ago

@shanepadgett, could you provide us more insight into what types of information you are looking to collect?

We are currently working on adding Hooks support to several of our server side SDKs. Currently the Hooks contain beforeEvaluation and afterEvaluation callbacks as part of the "Evaluation Series". We may bring support for this Hooks callback interface to the client SDKs in the future so that logging and analytics integrations can be made more easily. Does that sound like what you are looking for?

Go docs for Hook interface

Docs on OpenTelemetry integration that uses the Hook interface

shanepadgett commented 2 months ago

The Datadog documentation for adding automatic feature flag tracking only shows support for browser SDK and mentions putting in a request for this feature with your team. Here you will see how the inspector would work for web, but if you click on iOS for launch darkly it mentions no support. It sounds like your hooks are like inspectors for the web sdk?

https://docs.datadoghq.com/real_user_monitoring/guide/setup-feature-flag-data-collection/?tab=browser#launchdarkly-integration

https://docs.launchdarkly.com/sdk/features/inspectors

tanderson-ld commented 2 months ago

@shanepadgett, good news! A team member is starting on the implementation of Hooks for this SDK. Hooks is superseding the inspector capability and will meet your needs here. We intend to reach out to Datadog to have them update their docs. We'll respond back here again once the implementation is complete.

keelerm84 commented 2 months ago

@shanepadgett the hook implementation has been released in v9.7.0.

Here are some key points of documentation to help you get started.

Please let us know if you have any questions!