search

launchdarkly / java-server-sdk

LaunchDarkly Server-Side SDK for Java
Other
83 stars 56 forks source link

fat jar brings in duplicate copy of `launchdarkly-logging` #282

Closed bplommer closed 1 year ago

bplommer commented 2 years ago

Describe the bug The fat jar contains a copy of the launchdarkly-logging library but also introduces a transitive dependency on a separate jar of that library, resulting in duplicates on the classpath - see screenshot from IntelliJ below.

Screenshot 2022-10-04 at 17 19 49

Expected behavior The jar should either contain the logging library or introduce a dependency on a separate jar, but not both.

eli-darkly commented 2 years ago

Thanks for catching this. The intention is for that library not to be present in the jar, and there was supposed to be a build step to double-check that there are no such duplicated classes, but clearly something went wrong. We should be able to fix this pretty quickly.

eli-darkly commented 1 year ago

Sorry for the delay in releasing this patch. The 5.10.3 release removes the redundant dependency.

eli-darkly commented 1 year ago

I'm going to go ahead and close the issue, but please reopen it if you find that this did not solve the problem.