launchdarkly / js-client-sdk

LaunchDarkly Client-side SDK for Browser JavaScript
Other
109 stars 62 forks source link

[Goal Manager] Add context as an event payload key as expected by js-sdk-common #276

Closed seanr-cardless closed 1 year ago

seanr-cardless commented 1 year ago

Requirements

Related issues

https://github.com/launchdarkly/js-client-sdk/issues/275

Describe the solution you've provided

Describe alternatives you've considered

None

Provide a clear and concise description of any alternative solutions or features you've considered.

None

Additional context

A more detailed description can be found in the linked issue.

kinyoklion commented 1 year ago

Hello @seanr-cardless,

Thank you for looking into this. That is indeed a mistake and it should have a context, as you have added, and it doesn't need contextKeys (those will be generated internal to the common code).

So you can remove those, and we can move forward validating this PR.

Thank you, Ryan

seanr-cardless commented 1 year ago

Hi @kinyoklion,

Thanks for the update. I removed contextKeys from the payload.

Thanks for moving forward with validating this PR!

Sean

kinyoklion commented 1 year ago

@seanr-cardless Thank you for identifying and fixing this!