Closed seanr-cardless closed 1 year ago
Hello @seanr-cardless,
Thank you for looking into this. That is indeed a mistake and it should have a context, as you have added, and it doesn't need contextKeys (those will be generated internal to the common code).
So you can remove those, and we can move forward validating this PR.
Thank you, Ryan
Hi @kinyoklion,
Thanks for the update. I removed contextKeys
from the payload.
Thanks for moving forward with validating this PR!
Sean
@seanr-cardless Thank you for identifying and fixing this!
Requirements
Related issues
https://github.com/launchdarkly/js-client-sdk/issues/275
Describe the solution you've provided
context
as a key to the event payload for goal events. js-sdk-common does not send any events without the context key in the payload. This means all goal events are currently not being sent in the latest SDK versions.contextKeys
in the event payload because I wasn't sure what exactly these were doing and wanted to keep this change non-breaking and backwards compatibleDescribe alternatives you've considered
None
Provide a clear and concise description of any alternative solutions or features you've considered.
None
Additional context
A more detailed description can be found in the linked issue.