search

launchdarkly / js-core

LaunchDarkly monorepo for JavaScript SDKs
Other
12 stars 12 forks source link

chore: Skip yarn pack for jsr publish. #442

Closed yusinto closed 2 months ago

yusinto commented 2 months ago

This is needed otherwise the gha fails:

npm WARN exec The following package was not found and will be installed: jsr@0.12.2
Downloading JSR binary...
Download completed
Checking for slow types in the public API...
error: Aborting due to uncommitted changes. Check in source code or run with --allow-dirty
Child process exited with: 1
jsr publish failed
Error: Process completed with exit code 1.
kinyoklion commented 2 months ago

So we know what it thinks are "uncommitted changes". This runs after the changes are merged. Build artifacts?

yusinto commented 2 months ago

The tgz produced by yarn workspace $WORKSPACE pack caused it. I removed this because it is unnecessary for jsr.