search

launchdarkly / ld-find-code-refs

Build tool for automatically sending feature flag code references to LaunchDarkly
https://launchdarkly.com
Other
47 stars 34 forks source link

Move packages around to use as library #142

Closed InTheCloudDan closed 3 years ago

InTheCloudDan commented 3 years ago

There is additional work that could be done to decouple code references further but this is a first step.

For my use case search may not need to be moved but it already has public methods.

If the change proposed looks reasonable then the following is a TODO:

vlymar commented 3 years ago

Hey @InTheCloudDan, thanks for the heavy lifting here!

Move coderefs out of pkg directory which is legacy and remove pkg

Can you share more about pkg being legacy? I believe we followed the patterns in https://github.com/golang-standards/project-layout for this project but could see that being outdated now.

InTheCloudDan commented 3 years ago

@vlymar it looks like this issue is still open on it: https://github.com/golang-standards/project-layout/issues/10

They do reference this tweet from Brad Fitzpatrick though about it being legacy: https://twitter.com/bradfitz/status/1039512487538970624