launchdarkly / ld-find-code-refs

Build tool for automatically sending feature flag code references to LaunchDarkly
https://launchdarkly.com
Other
46 stars 34 forks source link

go 1.16 #149

Closed chenrui333 closed 3 years ago

chenrui333 commented 3 years ago
chenrui333 commented 3 years ago

let me know what you folks think on this PR, cc @InTheCloudDan @yusinto

vlymar commented 3 years ago

Thanks @chenrui333! Have you had a chance to test ld-find-code-refs built with go 1.16? Go tends to be good at backwards compatibility but we'll want to sanity check things. We'll try to get to testing and merging this shortly.

InTheCloudDan commented 3 years ago

I tested locally after last merge and this builds

chenrui333 commented 3 years ago

I have maintained bunch of homebrew go formulae, I did not observe any go1.16 build issues. And thanks @InTheCloudDan for testing it out. :)