search

launchdarkly / ld-find-code-refs

Build tool for automatically sending feature flag code references to LaunchDarkly
https://launchdarkly.com
Other
46 stars 34 forks source link

Error detecting git branch: expected branch name starting with refs/heads/, got: refs/tags/v... #155

Closed laurrentt closed 2 years ago

laurrentt commented 3 years ago

Using the provided Github Action workflow, when a tag is created, the find-code-ref action is triggered but fails because it doesn't seem to support tags refs.

vlymar commented 3 years ago

Thanks for the bug report! We'll take a look soon.

Andrei-Predoiu commented 3 years ago

We are experiencing exactly the same issue in CircleCI It makes it impossible to do release based deployments using the orb

arun-selva commented 3 years ago

We couldnt deploy release tags with launchdarkly and will be great if this feature is made available. Thanks

InTheCloudDan commented 3 years ago

@Andrei-Predoiu the source of the error @laurrentt mentioned is coming from our Github Actions implementation. Can you confirm the exact error message you are receiving when trying to use this with CircleCI?

InTheCloudDan commented 3 years ago

@Andrei-Predoiu understood, thanks for providing the logs it will help us narrow it down.

adomass commented 2 years ago

When will it be fixed? Code-refs are almost useless now because we use tags always.

carmenquan commented 2 years ago

@adomass, our team is going to do an investigation next week and will follow up here once completed. Thanks for your patience!

Cheers!

laupow commented 2 years ago

@carmenquan @jazanne what's the timeline for the next release?

Looking forward to the 2.3.x release for use with Circle CI (orb link) 🙏

carmenquan commented 2 years ago

@laupow We are preparing a release, but don't have a timeline just yet. I'll update this thread once something changes. Thanks for your patience!

carmenquan commented 2 years ago

Thanks for everyone's patience, we've released v2.4.0, which includes the fix to this issue 🎉

https://github.com/launchdarkly/ld-find-code-refs/releases/tag/2.4.0 https://circleci.com/developer/orbs/orb/launchdarkly/ld-find-code-refs

adomass commented 2 years ago

Now we get error like this ERROR: 2021/12/08 13:55:49 github-actions.go:49: error detecting git branch: expected ref name starting with refs/heads/ or refs/tags/, got: refs/tags/2021.12.5.1375

Looks like tag refs/tags/2021.12.5.1375 does not start with refs/tags/ :)