search

launchdarkly / ld-find-code-refs

Build tool for automatically sending feature flag code references to LaunchDarkly
https://launchdarkly.com
Other
46 stars 34 forks source link

Add additional debugging for extinction events #254

Closed InTheCloudDan closed 2 years ago

InTheCloudDan commented 2 years ago

Make it easier to find out why extinction searches are timing out for some github action runs.

jacobScottAllen commented 2 years ago

Looks good to me, not sure why the test is failing though.

I added @launchdarkly/squad-flag-lifecycle too since they own code refs currently and they may have some thoughts.

jazanne commented 2 years ago

@InTheCloudDan i think the tests on this are failing because of the logger - do you know if there's a way we can mock it in this test?

InTheCloudDan commented 2 years ago

@jazanne ohh great call! Unfortunately I'm not sure how, it does explain why it was still failing locally for me though with some additional changes.

tiffanylphan commented 2 years ago

Looks good to me, @jazanne! Thanks for fixing the test issue!