search

launchdarkly / ld-find-code-refs

Build tool for automatically sending feature flag code references to LaunchDarkly
https://launchdarkly.com
Other
46 stars 34 forks source link

[sc-164648] update more repo type info with gitlab #260

Closed jazanne closed 2 years ago

jazanne commented 2 years ago
shortcut-integration[bot] commented 2 years ago

This pull request has been linked to Shortcut Story #164648: allow gitlab as a repo type for code refs.

tiffanylphan commented 2 years ago

I noticed in some places the code snippet, eg: repoType is used. In other places code snippets are not used while referring to the same thing. We should have consistency.

jazanne commented 2 years ago

I noticed in some places the code snippet, eg: repoType is used. In other places cone snippets are not used while referring to the same thing. We should have consistency.

looks like nowhere that the backticks are used are they actually being displayed. just going to remove them

jazanne commented 2 years ago

I noticed in some places the code snippet, eg: repoType is used. In other places cone snippets are not used while referring to the same thing. We should have consistency.

looks like nowhere that the backticks are used are they actually being displayed. just going to remove them

nevermind, backticks are used in circleci orb because of yaml syntax with double quotes. not going to modify that file, but updated the flag opts to wrap names in double-quotes, which aligns to go file formatting