launchdarkly / ld-find-code-refs

Build tool for automatically sending feature flag code references to LaunchDarkly
https://launchdarkly.com
Other
46 stars 34 forks source link

[sc-157321] Allow designating `dir` in github action #294

Closed jazanne closed 5 months ago

jazanne commented 1 year ago

This is completely optional, but is useful if someone checks out multiple repos in their action.

For example, this git-gatsby workflow used to check out multiple repos internal repos

--

Dev notes

this must use env override and not github action input because of how env variable is used to find the configuration file etc.

shortcut-integration[bot] commented 1 year ago

This pull request has been linked to Shortcut Story #157321: github action should allow dir to be specified.

jazanne commented 1 year ago

@mmrj i had to change how this works, sorry to make ya re-review!

jazanne commented 1 year ago

@InTheCloudDan wasn't sure how to test this since, if you have thoughts i'd love to hear them.

InTheCloudDan commented 1 year ago

@jazanne yeah this is an interesting one, I'm not really sure what would be the best way to it. Maybe just a single unit test confirming what's set is correctly passed in??

jazanne commented 5 months ago

not high priority