search

launchdarkly / ld-find-code-refs

Build tool for automatically sending feature flag code references to LaunchDarkly
https://launchdarkly.com
Other
45 stars 34 forks source link

orb not able to read parameters from bash_env #311

Closed brondum closed 1 year ago

brondum commented 1 year ago

We would like not to store our LD_ACCESS_TOKEN in our context or in the repo it self. Instead we pull this from our secret store and populate it to $BASH_ENV as a pre_step. Currently the orb is running in sh instead of bash which means that CircleCI doesnt load bash_env automatically.

Solutions:

  1. Could be to change shell to bash
  2. source $BASH_ENV before the command

CircleCI docs explaining the use of env-vars and paramenters. https://circleci.com/docs/env-vars/#parameters-and-bash-environment

The $BASH_ENV workaround only works with bash, and has not been confirmed to work with other shells.

jazanne commented 1 year ago

@brondum thank you for submitting this issue. We will have the team review the proposed change and get back to you.

jazanne commented 1 year ago

@brondum thank you for your contribution fixing this issue. It is now available in orb version 2.9.0