launchdarkly / ld-find-code-refs

Build tool for automatically sending feature flag code references to LaunchDarkly
https://launchdarkly.com
Other
46 stars 34 forks source link

.ldignore file doesn't work for extinction searching #319

Open rspechenkin opened 1 year ago

rspechenkin commented 1 year ago

We have a GitHub repository with code written in Golang. We vendor all dependencies so there's a big vendor folder in the root of the repo that contains 3rd-party dependencies. We don't want to scan this folder so we have .ldignore file in the root of the repository. The content of this file is:

vendor/**

Despite this fact, if I make a commit and add new files to the vendor folder, I can see that the tool scans such files:

DEBUG: 2023/01/20 14:47:48 git.go:305: Examining from file: FROM_PATH and to file: vendor/test/test.md

It seems that it scans only files that were added in the commit but doesn't scan the files that were there before the commit. (we run the tool with --lookback 1 parameter to scan only the last commit)

Tool version: 2.8.0

jazanne commented 1 year ago

Hi @rspechenkin thank you for submitting this ticket.

I would like to clarify that the logs that you are seeing here are for the extinctions phase of code reference scanning run, not the search for existing references. Unfortunately, there is a known issue that the extinctions phase doesn't respect the configured .ldignore file.

If you are not using extinctions you can set --lookback 0 to turn off the extinctions scan.

I am very sorry for the inconvenience. We will follow-up if there are any changes to this issue.