search

launchdarkly / ld-find-code-refs

Build tool for automatically sending feature flag code references to LaunchDarkly
https://launchdarkly.com
Other
45 stars 34 forks source link

fix: update go-diff package #386

Closed ffluk3 closed 5 months ago

ffluk3 commented 10 months ago

Resolves #351, where the tool would throw index out of range errors for sufficiently large source code diffs. The downstream library was recently updated to allow for significantly larger diff max sizes, as discussed in the associated issue.

jazanne commented 10 months ago

hi @ffluk3, this version bump doesn't seem to contain to the fix here https://github.com/sergi/go-diff/pull/136 since a new tag hasn't been cut since it was merged.

ffluk3 commented 10 months ago

Ah I see. So the original issue was fixed: https://github.com/sergi/go-diff/issues/89. However, there was a small reported regression as a result of the fix. CLRF files seem to have issue still and the version needs to be bumped for that.

ffluk3 commented 5 months ago

@jazanne I've updated this PR to use the commit hash-based version that folds in the fix.

jazanne commented 5 months ago

closing in favor of https://github.com/launchdarkly/ld-find-code-refs/pull/425

thanks for your help on this one @ffluk3!