search

launchdarkly / ld-find-code-refs

Build tool for automatically sending feature flag code references to LaunchDarkly
https://launchdarkly.com
Other
46 stars 34 forks source link

update requests made to use 'state' filter; request deprecated flags #400

Closed cjhensen closed 11 months ago

cjhensen commented 11 months ago

Update archived api call to use new state filter

shortcut-integration[bot] commented 11 months ago

This pull request has been linked to Shortcut Story #220019: [Must have] Update code references to also request deprecated flags.

cjhensen commented 11 months ago

Hey @jazanne! 👋🏻 Is there anything else that needs to be done here? Also - these requests depend on a feature flag. Is there a way of flagging these updates? Or would this not get merged until the flag is released in gonfalon to prod?

jazanne commented 11 months ago

Hey @jazanne! 👋🏻 Is there anything else that needs to be done here? Also - these requests depend on a feature flag. Is there a way of flagging these updates? Or would this not get merged until the flag is released in gonfalon to prod?

Hey, thanks for starting this PR! we'll also need to update the api version being called here https://github.com/launchdarkly/ld-find-code-refs/blob/530ed7683769b20ef0ad05648ea947d64cf04969/internal/ld/ld.go#L45

We don't have flags enabled in this tool, so I would say we should hold off on merging until the feature is released