search

launchdarkly / ld-relay-helm

A helm chart to ease deployment of the LaunchDarkly Relay Proxy
Other
6 stars 12 forks source link

Support for dynamic envFrom k8s Secrets #44

Closed LiamStorkey closed 1 year ago

LiamStorkey commented 1 year ago

Is your feature request related to a problem? Please describe. Currently, the helm chart supports envfrom the configMapRef but this does not support secure string secrets (like sdk keys) as it would require them to be in plain text in the values files.

Describe the solution you'd like Allowing dynamic envFrom pre-existing k8s secrets. This would allow users to create k8s secrets that hold a bunch of key-value pairs (like the external secrets operator does via aws ssm) and the helm chart would create the environment variables from this secret. Removing the need for having secrets in the plain text of the values files. This could be a boolean toggle in the values files.

For now, we can leave the onus of creating/maintaining the k8s secret to the individual user. This way they can use any tool they would like to create the secret, as long as the secret name is <helm release name>-secret-environment-variables it will be picked up and used here.

LiamStorkey commented 1 year ago

Here is a PR for this issue https://github.com/launchdarkly/ld-relay-helm/pull/45

keelerm84 commented 1 year ago

Thank you for the issue and the PR. I will keep my communication focused there. Thanks again.

keelerm84 commented 1 year ago

This change is available in v2.3.0.