search

launchdarkly / ld-vscode

VSCode extension for LaunchDarkly
https://www.launchdarkly.com
Other
16 stars 8 forks source link

Store Refactor #43

Closed InTheCloudDan closed 4 years ago

InTheCloudDan commented 4 years ago

This PR refactors the Store to expose a public flagMetadata that other classes can consume. It also creates a new event emitter that those classes can listen to when there is a flag change. This is different that current implementation which exposes the ldclient On listener.

It also adds error handling into API class.

InTheCloudDan commented 4 years ago

This was overcomplicating the issue and trying to hide where the data is coming from. Going to close out and just use the necessary parts for a cleaner PR.