search

launchdarkly / node-server-sdk

LaunchDarkly Server-side SDK for Node
Other
79 stars 65 forks source link

allFlagsState hangs when passing callback but no options #114

Closed gabegorelick closed 6 years ago

gabegorelick commented 6 years ago

Even though the options parameter for allFlagsState is supposed to be optional [1], it's actually required when passing a callback:

ldClient.allFlagsState(user, callback); // this hangs
ldClient.allFlagsState(user, {}, callback); // this works

[1] https://github.com/launchdarkly/node-client/blob/62903ce09aa3311cecd126baff327958fc075eed/index.d.ts#L550-L569

eli-darkly commented 6 years ago

Whoops, sorry, thanks for catching that. We'll have a fix out shortly.

eli-darkly commented 6 years ago

Should work now.