search

launchdarkly / node-server-sdk

LaunchDarkly Server-side SDK for Node
Other
79 stars 65 forks source link

How should the error event be handled? #40

Closed mike-zorn closed 8 years ago

mike-zorn commented 8 years ago

Today's outage of the streaming api caused our authentication service to crash because https://github.com/launchdarkly/node-client/commit/e371a708e89903cfba15871251b4a4dd2a500a81 propagates the error event even though the retry mechanism is reconnecting the streaming client.

How should we be handling failure here? Should we handle the error event? It seems very odd to be handling a connection issue as an error even though the client is attempting to reconnect.

mike-zorn commented 8 years ago

Resolved by https://github.com/launchdarkly/node-client/pull/41.

Thanks!!!