launchdarkly / node-server-sdk

LaunchDarkly Server-side SDK for Node
Other
79 stars 65 forks source link

Closing a client using a NullUpdateProcessor crashes instead of closing #99

Closed dylanlingelbach closed 6 years ago

dylanlingelbach commented 6 years ago

If I create a Launch Darkly client that uses a NullUpdateProcessor and then I call close on that client, we will crash, because NullUpdateProcessor is currently defined without a close function:

function NullUpdateProcessor() {
  return {
    start: function(callback) {
      setImmediate(callback, null);
    }
  };
}

NullUpdateProcessor should define a no-op close function.