[sc-205159] Update README with current number of flags served

launchdarkly / openfeature-node-server

An open feature provider for the LaunchDarkly node SDK.

Other

10 stars 3 forks source link

[sc-205159] Update README with current number of flags served #21

Closed ember-stevens closed 1 year ago

ember-stevens commented 1 year ago

Story details: https://app.shortcut.com/launchdarkly/story/205159

shortcut-integration[bot] commented 1 year ago

This pull request has been linked to Shortcut Story #205159: Update intro text in SDK github repos.

ember-stevens commented 1 year ago

@yusinto are you able to help me fix these failing CircleCI tests? I don't understand the errors well enough to know why they are failing. Thank you!

yusinto commented 1 year ago

Looks like on main the tests are also failing with the same error:

 Object {
        "flagKey": "a-key",
    +   "flagMetadata": Object {},
        "reason": "OFF",
        "value": Object {
          "some": "value",
        },
    +   "variant": undefined,
      }

I think it could be that gonfalon has added more things to the server response so that broke the tests. It's safe for your changes to be merged, I'll submit a separate PR to fix the failing tests. Sorry for the slow response @ember-stevens !