search

launchdarkly / python-server-sdk

LaunchDarkly Server-side SDK for Python
https://docs.launchdarkly.com/sdk/server-side/python
Other
38 stars 45 forks source link

Can we loosen the semver requirement to include version 3.0? #214

Closed bkodes closed 1 year ago

bkodes commented 1 year ago

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I would love to see the SDK [...does something new...] Hey I am utilizing ld python sdk but i have conflicting semver versions with lancedb. Is there any chance we can loosen the requirement on semver here to include =<3.0 instead of <3.0?

Describe the solution you'd like A clear and concise description of what you want to happen. Can we evaluate what is needed to include semver 3.0? Version vs VersionInfo is my biggest conflict right now with your packages

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered. I will do whatever work needs to be done if we are okay with this

Additional context Add any other context about the feature request here.

keelerm84 commented 1 year ago

This SDK does not have a requirement on lancedb. It seems like this is more likely a problem with transitive dependencies. If you can make a small reproduction case, and send me the requirements.txt file, I can see if there is something we can do on our side.

bkodes commented 1 year ago

@keelerm84 hey sorry maybe i wasn't clear with my description. The issue is a dep conflict with semver between launchdarkly and lancedb requirements, not this sdk having a requirement on lancedb. for more context, lancedb utilizes semver.Version for checking their pydantic verisioning and this is because they have upgraded to semver version >=3.0. VersionInfo has become Version in semver 3.0 and higher. I get a build error with my project because launchdarkly python sdk has a constraint on semver keeping the version below 3.0. It's okay tho I forked this repo and changed the requirement on semver :) Thanks for the quick feedback tho

pierre-wehbe commented 1 year ago

@keelerm84 Can we please re-open this.

File: https://github.com/launchdarkly/python-server-sdk/blob/main/requirements.txt Current dependency: semver>=2.10.2,<3.0.0 Need: semver 3.0.1 (latest version here: https://pypi.org/project/semver/)

Can we loosen the semver requirement to include version 3.0?