search

launchdarkly / python-server-sdk

LaunchDarkly Server-side SDK for Python
https://docs.launchdarkly.com/sdk/server-side/python
Other
38 stars 44 forks source link

Stream and polling processor logging updates to warn on recoverable errors #219

Closed fritzdj closed 10 months ago

fritzdj commented 10 months ago

We are using a logging integration for internal alerting and we want to be able to filter out certain error logs where the LD client is running into a "recoverable" error if possible. Today we noticed there were HTTP responses with a 500 status being returned when StreamingUpdateProcessor was running -- this looked to be a minor blip. Could we log these at the warning level instead of the error level if these are 'expected' blips?

keelerm84 commented 10 months ago

@fritzdj thank you for this contribution. These changes look good to me. Can you also update the behavior in the polling processor so the behavior stays consistent between the two data sources?

Thank you!

fritzdj commented 10 months ago

@fritzdj thank you for this contribution. These changes look good to me. Can you also update the behavior in the polling processor so the behavior stays consistent between the two data sources?

Thank you!

@keelerm84, thanks for the review! I just pushed the same change for PollingUpdateProcessor.

keelerm84 commented 10 months ago

Fixed in 8.1.6

And once again, thank you for your contribution!