launchdarkly / python-server-sdk

LaunchDarkly Server-side SDK for Python
https://docs.launchdarkly.com/sdk/server-side/python
Other
38 stars 44 forks source link

fix: Gzip header should only be set on polling #262

Closed keelerm84 closed 5 months ago

keelerm84 commented 5 months ago

BEGIN_COMMIT_OVERRIDE chore: Gzip. header should only be set on polling END_COMMIT_OVERRIDE

shortcut-integration[bot] commented 5 months ago

This pull request has been linked to Shortcut Story #230875: Enable compression headers for python.

keelerm84 commented 5 months ago

When I originally made this change, it passed testing against our live endpoints. However, it doesn't seem like upstream is actually honoring these settings after all. If they do start supporting this encoding, then it looks like this would fail for streaming.

So for now, I'm only going to enable it on the portion I know should have it implemented.