search

launchdarkly / python-server-sdk

LaunchDarkly Server-side SDK for Python
https://docs.launchdarkly.com/sdk/server-side/python
Other
38 stars 45 forks source link

RedisFeatureStore should handle redis outage #67

Closed pdsarin closed 7 years ago

pdsarin commented 7 years ago

From my reading of the code and from some limited testing, the LaunchDarkly client gracefully handles unavailability of the LaunchDarkly service.

The RedisFeatureStore does not appear to handle outages gracefully. IMO it should return the default when redis is unavailable. (I discovered the problem when I had my redis URL misconfigured while running in ldd mode.)

drichelson commented 7 years ago

Thanks for bringing this to our attention. We'll be investigating soon.

drichelson commented 7 years ago

@pdsarin We've just released 4.0.1 which addresses this issue. Please let us know if it works for you.

pdsarin commented 7 years ago

Works great. Thank you!

On Tue, Jan 10, 2017 at 4:05 PM, Dan Richelson notifications@github.com wrote:

@pdsarin https://github.com/pdsarin We've just released 4.0.1 which addresses this issue. Please let us know if it works for you.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/launchdarkly/python-client/issues/67#issuecomment-271697578, or mute the thread https://github.com/notifications/unsubscribe-auth/AAuvezYIPq0MGJ4m0ZR3rqFdIdETgFa9ks5rQ_J-gaJpZM4LWTrD .