search

launchdarkly / react-client-sdk

LaunchDarkly Client-side SDK for React.js
Other
86 stars 68 forks source link

uuid package needs upgrade to version 7+ #107

Closed njlg closed 2 years ago

njlg commented 2 years ago

The js-sdk-common package got bumped to include a newer version of uuid (see https://github.com/launchdarkly/js-sdk-common/issues/46). Can we bump this package and include a newer version of uuid and js-sdk-common?

eli-darkly commented 2 years ago

Unfortunately there's a problem with that dependency update, which is why we have deliberately not updated js-client-sdk or react-client-sdk to include it yet. We need to revisit it so thanks for this reminder, but we can't simply bump the dependency at the moment.

njlg commented 2 years ago

Dang! I get tired of seeing these messages:

npm WARN deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.

:)

eli-darkly commented 2 years ago

I know. I wish I could remember what the problem was that we ran into, but I can't find it offhand - I'm sure it will show up again if I go back and try to do the update again. I believe it had something to do with the newer package not being quite as browser-compatible as it claimed to be— possibly relying on some Node dependency— it may have been a misunderstanding on our part but it did seem like some changes would be required other than just bumping the version.

XieX commented 2 years ago

We made some changes and no longer needed the uuid package, so it has been removed in 2.27.0.