Replace lodash.camelcase with custom snakeCaseToCamelCase

launchdarkly / react-client-sdk

LaunchDarkly Client-side SDK for React.js

Other

79 stars 67 forks source link

Replace lodash.camelcase with custom snakeCaseToCamelCase #143

Closed wojtekmaj closed 1 year ago

wojtekmaj commented 1 year ago

Requirements

[x] I have added test coverage for new or changed functionality
[x] I have followed the repository's pull request submission guidelines
[x] I have validated my changes against all supported platform versions

Describe the solution you've provided

Replaces lodash.camelcase with custom one liner, which of course has much more limited functionality, but does the job just fine, while shaving off ~7 KB from the package.

XieX commented 1 year ago

Flag keys can be any case you like, kebab case, snake case, or even whatever.you.would.call.this is possible. Love the prospect of cutting lodash.camelcase, but it does handle all of those cases.

We may be able to knock off a few kb with an alternative such as camelcase?

wojtekmaj commented 1 year ago

Oh. Didn't realize all possible key formats since the tests weren't really covering that.

XieX commented 1 year ago

Great catch, I'll see about adding some more tests! 💪