launchdarkly / react-client-sdk

LaunchDarkly Client-side SDK for React.js
Other
78 stars 67 forks source link

basicLogger set to `level: 'none'` does not disable console logs #286

Open wlannistamps opened 2 weeks ago

wlannistamps commented 2 weeks ago

Describe the bug Setting the basicLogger to level: 'none' does not disable console logs in React Web using either launchdarkly-react-client-sdk OR launchdarkly-js-client-sdk (per the documentation here: https://docs.launchdarkly.com/sdk/features/logging#react-web)

To reproduce

  1. import basicLogger into react using the launchdarkly-js-client-sdk (or the react version) import { basicLogger } from 'launchdarkly-js-client-sdk';
  2. Set the options object with a logger property logger: basicLogger({level: 'none'})
    const LDProvider = await asyncWithLDProvider({
    clientSideID: setup.launchDarklySdkKey,
    context: {
        'kind': 'user',
        'key': session.visitorId
    },
    options: {
        logger: basicLogger({level: 'none'})
    },
    reactOptions: {},
    });
  3. Refresh the app after compilation is complete

Expected behavior LaunchDarkly console logs should not appear

SDK version 3.2.0

Language version, developer tools Node 17.3.1, webpack 5.66.0

OS/platform Windows 10, Chrome 125

Additional context

davevanhoorn commented 1 week ago

I'm experiencing the same issue. We're using both the @launchdarkly/node-server-sdk and launchdarkly-js-client-sdk packages, for the node package this does seem to work:

logger: basicLogger({
  level: 'none',
}),