search

launchdarkly / react-client-sdk

LaunchDarkly Client-side SDK for React.js
Other
86 stars 68 forks source link

[Fixes for] Expose LDProvider as a standalone component #31

Closed Morton closed 4 years ago

Morton commented 4 years ago

This PR basically fixes the comments in https://github.com/launchdarkly/react-client-sdk/pull/28

yusinto commented 4 years ago

Hi @Morton thank you for helping out and fixing these. The changes you’ve made here look good, but we’d like to address these other requests too before merging the changes. The first is to add an example app in the examples folder to exemplify the use of the new Provider component. The second is to document this in our docs site.

Morton commented 4 years ago

Hi @yusinto, I understand and I don't mind contributing fixes. But my company is using (and paying) @launchdarkly so we don't need to build documentation and examples for our devs on our own 😉

Thanks Morton

bwoskow-ld commented 4 years ago

Hi @Morton ,

We understand where you're coming from -- your position is reasonable. The intent behind Yus's message was that each incremental contribution progresses the PR closer to meeting our criteria for being merged and released in an upcoming SDK version. If you have the bandwidth, and if the example code is contributed, then we'll be able to merge and release your changes more quickly.

As for the documentation -- it lives in a separate repository and can definitely be a follow-up task for the SDK team once this PR is merged and ready to be released in an SDK version.

Cheers, Ben

bwoskow-ld commented 4 years ago

Hi @Morton ,

Thanks again for making these changes. We've gone ahead and resolved merge conflicts which arose while your PR was sitting here. We're going to go ahead and merge this now. The SDK team will take on the remaining tasks mentioned above (example code sample + documentation).

This change will be included in the next React SDK release which we will aim to release in the upcoming week or two.