launchdarkly / react-client-sdk

LaunchDarkly Client-side SDK for React.js
Other
86 stars 70 forks source link

upgrade launchdarkly-js-client-sdk version to ^2.17.5 #34

Closed dpisani closed 4 years ago

dpisani commented 4 years ago

The react SDK is using a fixed version of launchdarkly-js-client-sdk, which is missing some important bug fixes. This upgrades the dependency and applies a caret range so future bugfixes in the JS SDK can be consumed.

I'm happy to change it back to a non-caret range if that's preferred.

eli-darkly commented 4 years ago

We deliberately use a fixed version dependency to avoid any ambiguity about what someone is getting when they install a specific version of one of our packages. The process is supposed to be that whenever we do a js-client-sdk release, we do a corresponding release of react-client-sdk (and electron-client-sdk)— however, clearly that process broke down at some point. Thanks for calling attention to this; we'll do the release within 24 hours.

dpisani commented 4 years ago

That makes sense. Thanks for the quick reply!