Add react 17 peer dependency

launchdarkly / react-client-sdk

LaunchDarkly Client-side SDK for React.js

Other

85 stars 68 forks source link

Add react 17 peer dependency #61

Closed maclockard closed 3 years ago

maclockard commented 3 years ago

Requirements

[ ] I have added test coverage for new or changed functionality
[x] I have followed the repository's pull request submission guidelines
[ ] I have validated my changes against all supported platform versions

Additional context

https://reactjs.org/blog/2020/10/20/react-v17.html

bwoskow-ld commented 3 years ago

Hi @maclockard,

Thanks for the pull request. We'll need to verify that the SDK doesn't have any unexpected issues with React 17. If that testing is fine then we'll move forward with this change.

Filed internally as 103643.

Cheers, @bwoskow-ld

maclockard commented 3 years ago

Awesome, thank you!

bwoskow-ld commented 3 years ago

Hi @maclockard ,

Thanks for pointing out this issue and proposing a fix. Our testing showed that the fix was a bit more involved than just this one-line peer dependency; as such I'll merge your pull request onto a temporary contrib branch and will then include it plus the additional changes in the next release.

Cheers, @bwoskow-ld

maclockard commented 3 years ago

Awesome, thank you!

bwoskow-ld commented 3 years ago

This is resolved in 2.22.2.