search

launchdarkly / react-native-client-sdk

LaunchDarkly Client-side SDK for React Native
Other
47 stars 32 forks source link

add tvOS target #151

Open todorone opened 2 years ago

todorone commented 2 years ago

We successfully use LaunchDarkly SDK for tvOS platform, it's fully compatible. This change is the only thing that is required for successful compilation.

louis-launchdarkly commented 2 years ago

Hello @todorone, thank you for the contribution! Because LaunchDarkly React Native SDK uses the LaunchDarkly iOS SDK as the native module for iOS (which supports tvOS), it is good that this works out for you.

We will discuss this with the React Native and iOS engineers, and if it makes sense, port the test (https://app.circleci.com/pipelines/github/launchdarkly/ios-client-sdk/95/workflows/74b1aea7-374f-425f-9a6f-8288b16e6cd3/jobs/635) into React Native SDK and accept the change.

todorone commented 2 years ago

Hello @todorone, thank you for the contribution! Because LaunchDarkly React Native SDK uses the LaunchDarkly iOS SDK as the native module for iOS (which supports tvOS), it is good that this works out for you.

We will discuss this with the React Native and iOS engineers, and if it makes sense, port the test (https://app.circleci.com/pipelines/github/launchdarkly/ios-client-sdk/95/workflows/74b1aea7-374f-425f-9a6f-8288b16e6cd3/jobs/635) into React Native SDK and accept the change.

thanks a lot, @louis-launchdarkly

what is approximate timeline for this - days, months, years, centuries? 😸