launchdarkly / react-native-client-sdk

LaunchDarkly Client-side SDK for React Native
Other
47 stars 32 forks source link

Fixing wrong parameter order on configureWithTimeout function on Android #193

Closed adamivancza closed 1 year ago

adamivancza commented 1 year ago

Requirements

Related issues

Lmk if you need an issue created for this.

Describe the solution you've provided

Changed the order of the params in the configureWithTimeout function as it wasn't matching the order on the JS and the iOS side.

Correct order (iOS & JS): config context timeout isContext

Incorrect order (Android): config context isContext timeout

Describe alternatives you've considered

Tried to fix this on the JS side first, but then noticed that iOS and JS is in alignment so I only updated Android.

Additional context

Repro: invoke configure with a timeout set. Example: await client.configure(config, user, 60);

Screenshot_1677838668