search

launchdarkly / react-native-client-sdk

LaunchDarkly Client-side SDK for React Native
Other
46 stars 32 forks source link

registerFeatureFlagListener does not fire when a flag changes due to identity changes #96

Closed vcarl closed 1 year ago

vcarl commented 2 years ago

Is this a support request? no

Describe the bug A listener registered with registerFeatureFlagListener is not triggered if the value changes due to a client.identify(…) call.

I can work around this by re-registering listeners when we make the identify call, but this was difficult to discover and will complicate our logic.

SDK version 5.0.1

gwhelanLD commented 2 years ago

Hi @vcarl,

Thanks for reporting this issue, we've filed it internally to investigate this and attempt to improve the experience. I think this may also be a point of platform consistency we need to address, which may require updating the native SDKs that this SDK wraps to really resolve this.

Thanks, @gwhelanLD

yusinto commented 1 year ago

@vcarl is this still an issue? Please update to the latest version 7.1.1 and verify.

karengrigoryan-sg commented 1 year ago

@yusinto still an issue for the version 7.1.1.

vcarl commented 1 year ago

It's been well over a year, and I'm no longer with the company I was with when I discovered this bug.

I do think it's important to say, the specific value of LaunchDarkly to me is simplifying reactivity for real-time feature flagging. Feature flagging without real-time reactivity is not difficult to do in-house, IME. That this bug, in what I view to be the absolute core of why I would want to use LaunchDarkly, has gone so long without being prioritized has led me to specifically recommend not using LD for React Native projects.

tanderson-ld commented 1 year ago

This issue has been fixed in 7.1.5.